Call kvmclock_ctrl on GDB requested pause#5007
Merged
JackThomson2 merged 2 commits intofirecracker-microvm:mainfrom Jan 24, 2025
Merged
Call kvmclock_ctrl on GDB requested pause#5007JackThomson2 merged 2 commits intofirecracker-microvm:mainfrom
JackThomson2 merged 2 commits intofirecracker-microvm:mainfrom
Conversation
roypat
previously approved these changes
Jan 22, 2025
Contributor
|
maybe worth a "fixes" entry in the changelog? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 245 245
Lines 26697 26697
=======================================
Hits 22194 22194
Misses 4503 4503
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
force-pushed
the
feat/kvm_clock_ctr_gdb
branch
from
374aaa9 to
b40150d
Compare
JackThomson2
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
Contributor
Author
Good shout I've added that in now thanks :) |
pb8o
previously approved these changes
Jan 22, 2025
When we pause for GDB call `KVM_KVMCLOCK_CTRL` to prevent guest softlockup watchdog panic. Signed-off-by: Jack Thomson <jackabt@amazon.com>
JackThomson2
force-pushed
the
feat/kvm_clock_ctr_gdb
branch
from
b40150d to
e63a17f
Compare
roypat
approved these changes
Jan 24, 2025
pb8o
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When we pause for GDB call
KVM_KVMCLOCK_CTRLto prevent guest softlockup watchdog panic.Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.